Merged
Conversation
H1: Double-start guard in Connection.start() H2: applyDeadLetterOptions returns new object instead of mutating input H3: QueueConsumer.handlers changed from readonly to private H4: handleMessage adds outer .catch for ack/nack failures M1: randomSuffix uses crypto.randomUUID() instead of Math.random() M3: appendHeartbeat uses URL class for parsing L1: Redact credentials from URL before logging Also refactors QueueConsumer constructor to use options object, extracts setupPublisher/setupConsumer/setupRequestConsumer methods, and updates tests to match new signatures.
peter-svensson
force-pushed
the
fix/code-review-findings
branch
from
fc894fb to
995c1ae
Compare
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Connection.start()to throw if already connectedapplyDeadLetterOptionspure by spreading input into new objectQueueConsumer.handlersfromreadonlytoprivatewithgetHandlers()accessor.catchon the handler promise chain inhandleMessageto catch ack/nack failuresMath.random()withcrypto.randomUUID()inrandomSuffix()URLclass for parsing inappendHeartbeat()with fallback for non-standard AMQP URLsstart()QueueConsumerconstructor to use options object (reduces positional params)setupPublisher,setupConsumer,setupRequestConsumerprivate methodsTest plan
bun run build)bun test)